This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[FRONT-476] make Menu scrollable #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazatarodi
requested review from
a team and
lorgan3
and removed request for
a team
JorenSaeyTL
previously approved these changes
Apr 7, 2023
|
@lowiebenoot I don't see it necessary, but in the case that we want to add it, I would add it in another PR. This one is huge enough. |
lorgan3
previously approved these changes
Apr 7, 2023
I thought we had it in the current Menu component, but apparently not, so nevermind. It's probably in popover that we have it. |
lowiebenoot
previously approved these changes
Apr 7, 2023
lowiebenoot
reviewed
Apr 7, 2023
farazatarodi
dismissed stale reviews from lowiebenoot, lorgan3, and JorenSaeyTL
via
6dfc80f
lorgan3
previously approved these changes
Apr 11, 2023
| const { height: viewportHeight } = getViewport(); | ||
|
|
||
| if (positionState === POSITION.TOP_LEFT || positionState === POSITION.TOP_RIGHT) { | ||
| return viewportHeight - top; | ||
| return viewportHeight - top - height - 24; |
… the document does the job
lorgan3
approved these changes
Apr 11, 2023
driesd
approved these changes
Apr 12, 2023
|
✅ checked |
lowiebenoot
approved these changes
Apr 12, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I meant to make
Menuscrollable, but I basically rewrote it.Screenshot before this PR
Screenshot after this PR
Breaking changes
Menu: State management now should happen in the parent component.Menu: TheonHideprop is now calledonInactive.Menu: TheonShowproperty is removed as the state management is now moved to the parent component.Menu: It now requires an anchor element for positioning when it is not static. Previously it was based on the parent element, which caused layout bugs inflexelements.