This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Select - Fix clear indicator styles
#2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeirlaenAaron
requested review from
a team,
jelledc,
lorgan3,
qubis741,
stefaandevylder,
eniskraasniqi1 and
driesd
and removed request for
a team
driesd
approved these changes
May 11, 2023
eniskraasniqi1
approved these changes
May 11, 2023
qubis741
approved these changes
May 11, 2023
lorgan3
approved these changes
May 11, 2023
farazatarodi
approved these changes
May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
getClearIndicatorStylesbecause it actually didn't work as we have a custom component for the clear indicator, these styles only work on the native react select components. Added the styling to the custom componentScreenshot before this PR
Screencast.from.11-05-23.09.25.17.webm
Screenshot after this PR
Screencast.from.11-05-23.09.24.41.webm
Breaking changes
N/A