This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Forward ref components #2803
Merged
Forward ref components #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowiebenoot
requested review from
lorgan3,
KristofColpaert,
driesd,
qubis741,
eniskraasniqi1,
JorenSaeyTL and
farazatarodi
lorgan3
reviewed
Nov 6, 2023
lorgan3
approved these changes
Nov 6, 2023
qubis741
approved these changes
Nov 6, 2023
driesd
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the update to the new tooltip we are getting some errors because the tooltipped component is not implenting ref forwarding. Due to this the tooltip can't add event handlers on the trigger and errors.
I added ref forwarding to almost all components. Some components are a bit more difficult to add ref forwarding and will not be tooltipped anyway, so they're not a problem at the moment.