This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Update multiselect style #2814
Merged
Update multiselect style #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorgan3
requested review from
a team,
lowiebenoot,
jelledc,
KristofColpaert,
driesd,
qubis741,
BeirlaenAaron and
farazatarodi
and removed request for
a team
driesd
approved these changes
Nov 29, 2023
BeirlaenAaron
approved these changes
Nov 30, 2023
farazatarodi
approved these changes
Dec 1, 2023
lowiebenoot
approved these changes
Dec 1, 2023
| - `MarketingMenuItem`: implementeed ref forwarding ([@lowiebenoot](https://github.com/lowiebenoot)) in [#2803](https://github.com/teamleadercrm/ui/pull/2803) | ||
| - `Label`: implementeed ref forwarding ([@lowiebenoot](https://github.com/lowiebenoot)) in [#2803](https://github.com/teamleadercrm/ui/pull/2803) | ||
| - `Bullet`: implementeed ref forwarding ([@lowiebenoot](https://github.com/lowiebenoot)) in [#2803](https://github.com/teamleadercrm/ui/pull/2803) | ||
| - `WysiwygEditor`: implemented ref forwarding ([@lowiebenoot](https://github.com/lowiebenoot)) in [#2803](https://github.com/teamleadercrm/ui/pull/2803) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the multiselect values to match our design which uses tags.
https://www.figma.com/file/LHH25GN90ljQaBEUNMsdJn/Teamleader-Components?node-id=37243%3A45897&mode=dev
Screenshot before this PR
Screenshot after this PR
Breaking changes
inverseis technically a breaking change but since we didn't use it and it's only visual I'm inclined to not mark it as such. Let me know if you disagree though.