This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
[FRAF-2895] - Allow passing color, backgroundColor to Tag
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eniskraasniqi1
requested review from
lowiebenoot,
lorgan3,
driesd,
qubis741,
gdegirmenci,
JorenSaeyTL and
farazatarodi
qubis741
previously approved these changes
Dec 20, 2023
eniskraasniqi1
force-pushed
the
FRAF-2895-allow-passing-color-to-tag-component
branch
from
8707d16
to
e015c37
Compare
qubis741
approved these changes
Dec 20, 2023
|
Manually checked ✅ |
gdegirmenci
approved these changes
Dec 21, 2023
JorenSaeyTL
approved these changes
Dec 21, 2023
eniskraasniqi1
changed the title
color, backgroundColor to Tag
farazatarodi
approved these changes
Dec 21, 2023
eniskraasniqi1
deleted the
FRAF-2895-allow-passing-color-to-tag-component
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently showing
Tagas in an error state is not possible, because color and background color is being overwritten.I passed color, and added one more case for background color as
Errorstate.Screenshot after this PR