feat(TA-471): add circle config #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darren-arbon
commented
Feb 21, 2024
| @@ -50,6 +50,6 @@ | |||
| "severity": "warning" | |||
| } | |||
| ], | |||
| "import-notation": "less" | |||
| "import-notation": "string" | |||
There was a problem hiding this comment.
Whilst this was not causing failures in the linting, less was apparently not a valid value and was causing the npm test step to fail
darren-arbon
commented
Feb 22, 2024
| "css-compile": "sass scss/:docs/assets/css/ --style=compressed --load-path=node_modules --source-map", | ||
| "css-lint": "stylelint scss/", | ||
| "format:stylelint": "stylelint scss/ --fix", |
There was a problem hiding this comment.
BW: re-ordered these in alpha
darren-arbon
commented
Feb 22, 2024
| "css": "npm-run-all css-compile css-prefix", | ||
| "format:stylelint": "stylelint scss/ --fix", | ||
| "prepare": "husky install", | ||
| "publish:githubpages": "gh-pages --dist docs", |
There was a problem hiding this comment.
This is new and needed for the circle config
darren-arbon
commented
Feb 22, 2024
| @@ -46,6 +47,7 @@ | |||
| "@commitlint/cli": "17.6.1", | |||
| "@commitlint/config-conventional": "17.6.1", | |||
| "autoprefixer": "10.4.14", | |||
| "gh-pages": "6.1.1", | |||
There was a problem hiding this comment.
This package allows us to do the release to github pages
darren-arbon
requested review from
pogotc,
twba-a,
klaudija-lawrence,
ellyd88 and
TomBirbeckTFS
twba-a
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TA-471
Make this repo align with our other repos and use circle for stuff.
Change/Fix
This was the original config for github pages deploy
It has been changed to this
a. Start
b. Be Kind To Your Colleagues
c. Lint and test
This runs on all branch and main builds. Does the linting checks
d. Push to Github Pages
This only runs if the linting passes, and if the branch is main
gh-pageswhich pushes to thegh-pagesbranch which is used in the above config, circle needed an SSH token that had write permissions, the default ones just have write, so an SSH key was made to work with this.This has been tested and works fine.
Checklist