Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added "Non Data Contact" toggle behavior to Generalized Search [CHI-2933] #737

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

GPaoloni
Copy link
Collaborator

@GPaoloni GPaoloni commented Sep 9, 2024

This PR is related to techmatters/flex-plugins#2512

Description

This PR adds support for it's UI counterpart, to add "Non Data Contact" toggle behavior to Generalized Search. To do so:

  • Contacts mapping has been modified to include isDataContact boolean property (ElasticSearch).
  • When the contact is indexed, we compute above property by using rawJson.callType.
  • When a search is performed, we add an addition filter: if onlyDataContacts is present in the query, we add a filter clause to match only contacts that have isDataContact field set to true.

IMPORTANT ‼️
This changes require a complete reindex of all the documents.

Checklist

Verification steps

  • Indexing lambda is already deployed so you can skip this step.
  • Deploy this branch to HRM development server. Alternatively you can run this branch locally, point to dev DB and ES instaces, but that might be more effort :P
  • Start a new local Flex using this branch.
  • After a search is performed, confirm that the "Non Data Contacts" toggle behaves as expected. Easiest way to do this is by checking that the amount of contacts greatly reduces if you set this toggle to true.
    • Ideally you can also check on HRM logs, where we are temporarily logging the search query, that it includes the appropriate filter on isDataContact field.

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@GPaoloni GPaoloni changed the title chore: add isDataContact property to contact mapping, use to add filt… chore: added "Non Data Contact" toggle behavior to Generalized Search [CHI-2933] Sep 9, 2024
@GPaoloni GPaoloni marked this pull request as ready for review September 9, 2024 21:52
Copy link
Contributor

@mythilytm mythilytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I haven't tested but LGTM

@GPaoloni GPaoloni merged commit 9284f42 into master Sep 11, 2024
13 checks passed
@GPaoloni GPaoloni deleted the gian_CHI-2933 branch September 11, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants