-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No response to Ctrl+Alt+V #1
Comments
Have you tried restarting brackets after installing the extension?, and does it work then? I put a warning note in settings dialog that you may need to restart incase you change shortcut keys, I will try to recreate it |
I have restarted my whole PC. Also I have no options to edit settings for this add-on. |
That is interesting that you don't even have menu options, which means extension is not loaded at all. Only way to find the cause is to run 'developer tools' F12 and then 'Reload with Extensions' F5 while looking at the console to check for any exceptions, as I couldn't recreate this in my machine (and also tried on Ubuntu pc as well). If you could provide any error messages from TechNet.clipbox in developer tool console panel that would be really helpful. |
I will do this. *EDIT https://pibin.net/?984b6294933ee365#PQKme19o3MqeL/TuHVOr+bojjAb0D2cz6Qm3fJSeoms= Pasted full console there. Also the certificate is self signed. *EDIT This is the expanded version of the console: https://pibin.net/?d78d53214d870c00#CT06+VbJfRbXmj+q6OGgN+JWp0USZyz0r9JUQCh6AF0= On 3 Oct 2014 00:13, "technet" [email protected] wrote:
|
Ok now I get clear idea what's happening, brackets uses loadash and it is available to any extension to use as well, so I used lodash for certain operations, now it seems like it complaining about it. The problem is to find have they restricted or changed using lodash. I will check on this. But the issue I'm having is I'm also using same version of brackets, and it's working fine. thanks a lot for investigation. I will go through the error log you sent and see what else could cause this to happen |
For example check this It is to add I will create small extension (nothing much just use |
Can you please create new folder /*jslint vars: true, plusplus: true, devel: true, nomen: true, regexp: true, indent: 4, maxerr: 50 */
/*global define, brackets, $, _, Mustache */
define(function (require, exports, module) {
"use strict";
var AppInit = brackets.getModule("utils/AppInit");
function loadPreferences() {
var temp1 = 10;
if (!_.isNaN(temp1) && temp1 > 0) {
console.log("brackets.clipboks >> temp1 is a number:" + temp1);
} else {
console.log("brackets.clipboks >> temp1 is not a number");
}
var temp2;
if (!_.isUndefined(temp2) && temp2.length > 0) {
console.log("brackets.clipboks >> temp2 is not undefined:" + temp2);
} else {
console.log("brackets.clipboks >> temp2 is undefined");
}
var temp3 = "valid";
if (!_.isUndefined(temp3) && temp3.length > 0) {
console.log("brackets.clipboks >> temp3 is not undefined:" + temp3);
} else {
console.log("brackets.clipboks >> temp3 is undefined");
}
}
AppInit.appReady(function () {
loadPreferences();
});
}); Which does nothing except using few lodash methods (and using lodash functions are recommended by brackets) so if you get same error like
Let me know the status |
I will do this ASAP. Been AFK. |
I didn't get any of the above. I got this though:
|
I did a clean install with only your extension. That didn't work. |
I'm still not sure why it's just you getting this error especially when brackets documentation says we must use lodash functions, anyway I bundled lodash together with the extension and release new version 0.2.1 can you please upgrade the extension and check, Please let me know the status so I can close this bug thanks again |
That seems to have fixed all problems. Shall I close this? Thank you |
I saw this extension was updated via Twitter, and having seen the Brackets feature request for this, I decided to check it out. Upon seeing what the newest released fixed, I felt the need to make a comment here, as a fellow extension dev. :) Lodash is in fact available to extensions. See how are using Thus, to access Bracket's copy of lodash and not bundle it yourself, simply use You can use this same method to access nearly every single module Brackets uses, original or third party. :) Also, good job on avoiding deprecated APIs. I actually have a pull request in right now to remove that. 👍 |
Thanks a lot @le717 I actually used and able to work even without get the lodash module using First I thought using Anyway I'm learning how to write extension by going through many source codes and bracket core source as well. I will change the code to use lodash by getModule and remove the bundled version, if that is the best way |
That is an excellent question. If more details can be gathered, I'd try to ask a dev on IRC chat about that.
The documentation on that particular function is probably not the clearest. When it is say use
I haven't actually seen an extension bundle lodash directly... Authors often bundle third party modules with their extension, but that usually stems from their use of a module that Brackets does not use.
I've never seen that in the guidelines, but I could have overlooked it. :)
That is a good way to learn, but a lot of things can be learned only by experimentation and doing it yourself. ;)
Not to sound like a broken record, but unless Brackets does not use the module you need or require a prerelease version, it's safe and (personally) recommended to use the internal Brackets module. Most of those modules are not going anywhere, and as long as you pay attention to development (IMO, the best way to do that is to run straight from git 😄) and any pending deprecations or removals, you will be fine. 😃 |
Initial version simply used underscore directly and in my environment I didn't get any error. Probably many others didn't as well. That's why I created simple extension which uses
Well I found it, but actually it refers to node modules, since it was talking above dependency I thought it is good to package lodash with the extension Here's the link
How about well known "extension rating" extension. I think I decided to package lodash after I found that even famous extensions do that :) https://github.com/dnbard/brackets-extension-rating/tree/master/extension/vendor |
So this isn't fixed then? |
@tomas-samot bug is fixed, the discussion was to use whether brackets' thirdparty lodash or to ship lodash with the extension. Moreover how brackets allow to use thanks again for your time on this issue and helping me to analyse. |
I closed the issue, but comments are welcome |
On the current build of brackets:
sprint 43 experimental build 0.43.0-14375 (release 287868769)
build timestamp: Tue Sep 02 2014 14:41:39 GMT-0700
There is no quick open box when using the assigned short cut.
As a side note, when installing the add-on brackets does not warn you that it needs to be restarted.
The text was updated successfully, but these errors were encountered: