Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP: do not merge] fixup/ci: feature-gate stabilized compiler features #24

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmsyn
Copy link

@rmsyn rmsyn commented Aug 30, 2023

Adds conditional feature-gates based on rustc version to only include unstable features on older compiler versions.

Introduces the rustversion dependency to handle the feature-gates.

Fixes breaking CI builds.

Adds conditional feature-gates based on `rustc` version to only include
unstable features on older compiler versions.

Introduces the `rustversion` dependency to handle the feature-gates.

Fixes breaking CI builds.
@rmsyn rmsyn changed the title fixup/ci: feature-gate stabilized compiler features [WIP: do not merge] fixup/ci: feature-gate stabilized compiler features Aug 30, 2023
@rmsyn rmsyn marked this pull request as draft August 30, 2023 04:24
@rmsyn
Copy link
Author

rmsyn commented Aug 30, 2023

This fix is broken due to proc_macro errors, so another solution for conditional compilation based on rustc version is needed, or some fix for the proc_macro errors.

... or you could just bump the MSRV ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant