Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewClientWithJSONSlogger #95

Merged
merged 9 commits into from
Nov 7, 2023

Conversation

itishrishikesh
Copy link
Contributor

Please review the below changes included with this PR,
-- Added NewClientWithJSONSlogger to print logs in JSON format.
-- Some changes in the Readme file for the above function.
-- An example under cmd/examples for the above function.

@bhagatvansh
Copy link
Contributor

LGTM!

Copy link
Contributor

@vaibhav-kaushal vaibhav-kaushal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one teeny tiny change required in the readme. Rest looks good.

client/README.md Outdated Show resolved Hide resolved
@vaibhav-kaushal vaibhav-kaushal merged commit 06e8282 into techrail:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants