Allow cli flags to set logically False values #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing, `--disable-refresh False` failed to override the default True value. This fix changes the logic so that properties are overwritten as long as an argument is not None. Before it only overwrote a property if an argument value was logically True. This bug effects every command line argument that overrides a property.
|
The unit tests are failing because this commit depends on: #57. |
JonRoma
approved these changes
Feb 3, 2021
zdc217
approved these changes
Feb 3, 2021
mpitcel
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing,
--disable-refresh Falsefailed to override thedefault True value. This fix changes the logic so that properties
are overwritten as long as an argument is not None. Before it only
overwrote a property if an argument value was logically True. This
bug effects every command line argument that overrides a property.