-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalid selection error message #71
Add invalid selection error message #71
Conversation
f7bfa3d
to
a972960
Compare
Since I assume this will result in a .1 point release, we should include a ChangeLog.md update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include a ChangeLog update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the suggestion about updating ChangeLog, and have two comments of my own.
@edthedev do we have a team standard for the format of the change log? I know Rokwire has one that is decent. Also should I go back through the history and write up a change log for each version release? |
@ddriddle Yes, we use the same standard as Rokwire - https://keepachangelog.com/en/1.0.0/ It would be neat to have ChangeLog for past releases, but I've also just ended the ChangeLog file with a link to the Git releases that says "For older versions, see ... " |
e9bfd0a
to
87e4f1f
Compare
I just recommended this website to @JonRoma :) |
I am ready to approve pending CHANGELOG updates |
In previous releases an invalid selection caused a traceback to be printed to the user. In the current release no error message is displayed. With this commit an error message is issued to the user on an invalid selection. This is sufficient since the user does not need to reauthenticate on additional login attempts.
87e4f1f
to
16c5aa0
Compare
In previous releases an invalid selection caused a traceback to be
printed to the user. In the current release no error message is
displayed. With this commit an error message is issued to the user
on an invalid selection. This is sufficient since the user does not
need to reauthenticate on additional login attempts.