Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalid selection error message #71

Conversation

ddriddle
Copy link
Collaborator

In previous releases an invalid selection caused a traceback to be
printed to the user. In the current release no error message is
displayed. With this commit an error message is issued to the user
on an invalid selection. This is sufficient since the user does not
need to reauthenticate on additional login attempts.

@ddriddle ddriddle added the bug Something isn't working label Feb 10, 2021
@ddriddle ddriddle self-assigned this Feb 10, 2021
@ddriddle ddriddle force-pushed the feature/invalid-selection-error-handling branch from f7bfa3d to a972960 Compare February 10, 2021 20:40
@edthedev
Copy link
Contributor

Since I assume this will result in a .1 point release, we should include a ChangeLog.md update.

Copy link
Contributor

@edthedev edthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include a ChangeLog update.

zdc217
zdc217 previously approved these changes Feb 10, 2021
Copy link
Collaborator

@JonRoma JonRoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the suggestion about updating ChangeLog, and have two comments of my own.

src/tests/test_util.py Outdated Show resolved Hide resolved
@techservicesillinois techservicesillinois deleted a comment from JonRoma Feb 10, 2021
@ddriddle
Copy link
Collaborator Author

@edthedev do we have a team standard for the format of the change log? I know Rokwire has one that is decent. Also should I go back through the history and write up a change log for each version release?

@edthedev
Copy link
Contributor

@ddriddle Yes, we use the same standard as Rokwire - https://keepachangelog.com/en/1.0.0/

It would be neat to have ChangeLog for past releases, but I've also just ended the ChangeLog file with a link to the Git releases that says "For older versions, see ... "

@ddriddle ddriddle force-pushed the feature/invalid-selection-error-handling branch 2 times, most recently from e9bfd0a to 87e4f1f Compare February 11, 2021 05:27
@mpitcel
Copy link
Contributor

mpitcel commented Feb 11, 2021

@ddriddle Yes, we use the same standard as Rokwire - https://keepachangelog.com/en/1.0.0/

It would be neat to have ChangeLog for past releases, but I've also just ended the ChangeLog file with a link to the Git releases that says "For older versions, see ... "

I just recommended this website to @JonRoma :)

@mpitcel
Copy link
Contributor

mpitcel commented Feb 11, 2021

I am ready to approve pending CHANGELOG updates

In previous releases an invalid selection caused a traceback to be
printed to the user. In the current release no error message is
displayed. With this commit an error message is issued to the user
on an invalid selection. This is sufficient since the user does not
need to reauthenticate on additional login attempts.
@ddriddle ddriddle force-pushed the feature/invalid-selection-error-handling branch from 87e4f1f to 16c5aa0 Compare February 15, 2021 22:23
@ddriddle
Copy link
Collaborator Author

@JonRoma and @edthedev I have added a CHANGELOG entry. Please add your approval when you have some time.

@ddriddle ddriddle merged commit feb8b08 into techservicesillinois:master Feb 16, 2021
@ddriddle ddriddle deleted the feature/invalid-selection-error-handling branch February 16, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants