Allow commands whose output is not logged unless they fail #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
4 tasks
lukaszachy
approved these changes
Mar 12, 2024
psss
added
code | utils
There is a class of commands whose output is interesting only when they fail. Allow running them, and do not log their output in real-time, but log it if the command exits with non-zero exit code.
psss
force-pushed
the
command-run-stream-disabled
branch
from
39ae7a5
to
632f291
Compare
|
Failing test is an unrelated issue #2744. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a class of commands whose output is interesting only when they fail. Allow running them, and do not log their output in real-time, but log it if the command exits with non-zero exit code.
Pull Request Checklist