Install dependencies of upgrade tasks

[martinhoyer]

Fixes #2643.

Pull Request Checklist

• implement the feature
• extend the test coverage
• include a release note

[psss]

@martinhoyer, could you please include a simple test checking that beakerlib would be installed even if the test which is executed is using shell as the framework? I'd suggest to create a slightly modified copy of /tests/execute/upgrade/simple which would select only the shell test:

tmt/tests/execute/upgrade/simple.sh

Lines 13 to 18 in 159b37c

	rlRun -s "tmt -c upgrade-path="${PATH}" \
	run --scratch -avvvdddi $run --rm --before finish \
	plan -n /plan/no-path \
	execute -h upgrade -t '/tasks/prepare' \
	provision -h container -i fedora:${PREVIOUS_VERSION}" \
	0 "Run a single upgrade task"

[lukaszachy]

Just a note that 'upgrade path' doesn't need to run distro update - it can be any plan. E.g. in #2643 (comment) it is quite fast.
We have 1 existing test which does the distro upgrade and that is IMO enough. All we need to do for this PR is to assert 'upgrade path' dependenicies are installed. No need to waste time in ugrading distro

[lukaszachy]

LGTM.

IMO also worth of release note

[martinhoyer]

Just a note that 'upgrade path' doesn't need to run distro update - it can be any plan. E.g. in #2643 (comment) it is quite fast. We have 1 existing test which does the distro upgrade and that is IMO enough. All we need to do for this PR is to assert 'upgrade path' dependenicies are installed. No need to waste time in ugrading distro

Thanks @lukaszachy , I'm trying to adapt your reproducer, but I'm not super sure how to modify it so it passes the tmt lint.

btw, I've found a small dummy-test-package-crested package to add as require in the upgrade task: Total download size: 11 k; Installed size: 6.9 k

[lukaszachy]

I'm trying to adapt your reproducer, but I'm not super sure how to modify it so it passes the tmt lint.

It smells with linter bug. I have same 'warn' reported for in plans for /tests/execute/upgrade (in /data).
Especially the warn C000 value of "how" is not "tmt" check...

[psss]

Just a note that 'upgrade path' doesn't need to run distro update - it can be any plan. E.g. in #2643 (comment) it is quite fast. We have 1 existing test which does the distro upgrade and that is IMO enough. All we need to do for this PR is to assert 'upgrade path' dependenicies are installed. No need to waste time in ugrading distro

Yes, and /tests/execute/upgrade/simple actually does not run the whole upgrade as it selects only /tasks/prepare from the upgrade repo which does almost nothing. My suggestion was to just do something like this:

tmt run --all -v
    plan --name /plan/no-path
    test --name /test/shell
    provision --how container --image fedora:39
    execute --how upgrade --test /tasks/prepare

Which should be fast enough and would verify that beakerlib is installed as the upgrade task requires it but /test/shell does not.

[psss]

/packit test

[psss]

IMO also worth of release note

Yeah, makes sense, added one in 376efe0 with some minor adjustments.

[psss]

Looks good, thanks for working on this. Added just a few minor suggestions.

[mmacura311]

sanity tested this functionality with following copr builds:

tmt-1.33.dev29+g2879190a-main.fc40.noarch
tmt+export-polarion-1.33.dev29+g2879190a-main.fc40.noarch
tmt+report-junit-1.33.dev29+g2879190a-main.fc40.noarch
tmt+report-polarion-1.33.dev29+g2879190a-main.fc40.noarch
tmt+provision-beaker-1.33.dev29+g2879190a-main.fc40.noarch
tmt+provision-container-1.33.dev29+g2879190a-main.fc40.noarch
tmt+provision-virtual-1.33.dev29+g2879190a-main.fc40.noarch
tmt+test-convert-1.33.dev29+g2879190a-main.fc40.noarch
tmt+all-1.33.dev29+g2879190a-main.fc40.noarch

did run an upgrade test that require beakerlib in the pre-upgrade test already at the beginning, and second one where requirement is added only at the upgrade phase. Both tests passed.