Fix inability of rpm-ostree to install multiple packages #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
test coverage
happz
force-pushed
the
rpm-ostree-install-multiple-and-the-fallout
branch
2 times, most recently
from
20a594f
to
f9a1b0d
Compare
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
rpm-ostree-install-multiple-and-the-fallout
branch
from
f9a1b0d
to
944feff
Compare
lukaszachy
approved these changes
Apr 30, 2024
|
So this PR now depends on #2828, right? |
Correct, and adds Alpine among the container images to test |
happz
force-pushed
the
rpm-ostree-install-multiple-and-the-fallout
branch
from
944feff
to
c97b9b8
Compare
thrix
reviewed
Apr 30, 2024
thrix
reviewed
Apr 30, 2024
thrix
reviewed
Apr 30, 2024
thrix
reviewed
Apr 30, 2024
That's 3 lines removed. The rest of 800+ lines of the patch consist of various improvements to related tests: * new unit test, uses package managers directly to install multiple packages, * `prepare/install` test refactored and extended to cover more distros when testing the basic operations, through parametrization, * added new custom images to make tests cover "ostree" scenario * plenty of `TODO` comments that should be resolved later.
happz
force-pushed
the
rpm-ostree-install-multiple-and-the-fallout
branch
from
ea82cf1
to
97a3cb4
Compare
psss
approved these changes
May 2, 2024
psss
added
the
priority | must
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
That's 3 lines removed. The rest of 800+ lines of the patch consist of various improvements to related tests: * new unit test, uses package managers directly to install multiple packages, * `prepare/install` test refactored and extended to cover more distros when testing the basic operations, through parametrization, * added new custom images to make tests cover "ostree" scenario * plenty of `TODO` comments that should be resolved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's 3 lines removed. The rest of 800+ lines of the patch consist of various improvements to related tests:
prepare/installtest refactored and extended to cover more distros when testing the basic operations, through parametrization,TODOcomments that should be resolved later.Pull Request Checklist