Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the information about used beakerlib libraries #3208

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

seberm
Copy link
Collaborator

@seberm seberm commented Sep 12, 2024

Print the "calculated" url, ref and path of the used beakerlib libraries which will be cloned by tmt. Print the information in verbose mode of level=3.

Fixes:

$ tmt -r ~/tmt-learning/03-beakertest run --until discover -vvv report --how display
...
/plans/example
summary: Basic smoke test
    discover
        how: fmf
        order: 50
        directory: /home/user/tmt-learning/03-beakertest
        using remote git library:
            url: https://github.com/beakerlib/tuned
            ref: master
            path: /basic
        using remote git library:
            url: https://github.com/beakerlib/openssl
            ref: devel
            path: /certgen
        summary: 1 test selected
            /tests/example
    report
        how: display
        order: 50
        summary: no results found
...

CC: @psss , @yarda

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • include a release note

@seberm seberm added step | discover Stuff related to the discover step area | libraries Issues related to beakerlib libraries support code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 12, 2024
@seberm seberm self-assigned this Sep 12, 2024
tmt/libraries/beakerlib.py Outdated Show resolved Hide resolved
@seberm seberm force-pushed the feature/log-remote-beakerlib-library branch from 02415b8 to 1316af1 Compare September 12, 2024 11:23
@seberm seberm requested a review from happz September 13, 2024 09:55
@seberm seberm added this to the 1.37 milestone Sep 16, 2024
@seberm seberm force-pushed the feature/log-remote-beakerlib-library branch from 1316af1 to b0a27c3 Compare September 18, 2024 17:52
@seberm seberm added the ci | full test Pull request is ready for the full test execution label Sep 19, 2024
@psss psss force-pushed the feature/log-remote-beakerlib-library branch from b0a27c3 to bfe8a77 Compare September 20, 2024 15:12
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! Looks good. Added a simple test coverage in 3a76959 and a short mention to release notes in bfe8a77.

@psss psss assigned psss and unassigned seberm Sep 20, 2024
@psss psss changed the title Log the information about used remote beakerlib libraries Log the information about used beakerlib libraries Sep 20, 2024
@psss psss linked an issue Sep 20, 2024 that may be closed by this pull request
@seberm
Copy link
Collaborator Author

seberm commented Sep 20, 2024

Thanks for implementing this! Looks good. Added a simple test coverage in 3a76959 and a short mention to release notes in bfe8a77.

Great, thanks!

@psss psss merged commit 24a75c1 into main Sep 20, 2024
22 of 23 checks passed
@psss psss deleted the feature/log-remote-beakerlib-library branch September 20, 2024 19:40
@seberm seberm self-assigned this Sep 24, 2024
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | libraries Issues related to beakerlib libraries support ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. step | discover Stuff related to the discover step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please print from where tmt is loading beakerlib libraries
4 participants