-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test result
key should be implemented as enum, not a string
#3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | style
Code style changes not affecting functionality
code | no functional change
"No Functional Change" intended. Patch should not change tmt's behavior in any way.
labels
Oct 1, 2024
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
October 1, 2024 11:57
martinhoyer
approved these changes
Oct 1, 2024
seberm
approved these changes
Oct 2, 2024
psss
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
psss
force-pushed
the
test-result-shall-be-enum
branch
from
October 3, 2024 07:48
3bbff0c
to
50563c7
Compare
psss
added
ci | full test
Pull request is ready for the full test execution
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
labels
Oct 3, 2024
Seems we have a little regression:
|
Addressed in bad555b |
This is a leftover from transitioning to enums in the past.
happz
force-pushed
the
test-result-shall-be-enum
branch
from
October 3, 2024 18:12
1538df9
to
c32b7e7
Compare
Failing test is an unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci | full test
Pull request is ready for the full test execution
code | no functional change
"No Functional Change" intended. Patch should not change tmt's behavior in any way.
code | style
Code style changes not affecting functionality
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover from transitioning to enums in the past.
Pull Request Checklist