Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging in without setting a position #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tegob
Copy link

@tegob tegob commented Aug 8, 2016

This is equivalent to logging in using the official game client while the “GPS signal not found” message displays.

See #142 (comment).

This is equivalent to logging in using the official game client while the “GPS signal not found” message displays.
@tegob tegob changed the title Remove NoPlayerPositionSetException Allow logging in without setting a position Aug 8, 2016
@Wegi
Copy link

Wegi commented Aug 8, 2016

I am strongly for merging this pull request. My app also does not need the location, and as the Twitch/Niantic Guidelines indicated GPS Spoofing is seen as a major problem, while just using the api for informational use is fine.

@n2o
Copy link

n2o commented Aug 8, 2016

+1 need this feature!

@elliottcarlson
Copy link
Contributor

elliottcarlson commented Aug 8, 2016

I don't think this should be part of the pgoapi repo. As it currently stands, the signature field that is included in the newer version of the repo needs the location as part of the signature. The signature can, and most reasonably, be activated for all calls going forward, making this change unnecessary. You can just sub-class pgoapi and override your own call statments if you need this functionality in your project.

@Wegi

while just using the api for informational use is fine

That's not how it works, that's not how any of this works.

@Wegi
Copy link

Wegi commented Aug 8, 2016

I don't think they treat users making get_inventory calls without location spoof the same as people getting map_objects and catching Pokemon with spoofed Location. Time will tell, and im sure since you're not working for Niantic you don't know as well how any of it works. Its as good speculation as any.

@elliottcarlson
Copy link
Contributor

Don't spread fud about it being fine when you are speculating as well.

@tegob
Copy link
Author

tegob commented Aug 8, 2016

@elliottcarlson

You can just sub-class pgoapi and override your own call statments if you need this functionality in your project.

Would you mind sharing an quick code example of that? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants