Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Postgis #185

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Upgrade Postgis #185

merged 3 commits into from
Apr 2, 2024

Conversation

3nids
Copy link
Contributor

@3nids 3nids commented Mar 13, 2024 •
edited
Loading

fixes #20

that would probably deserve some documentation about invalid PG versions

@ponceta ponceta linked an issue Mar 13, 2024 that may be closed by this pull request
Current code is invalid with Postgis 3.2+ #20
Closed
@ponceta ponceta self-requested a review March 13, 2024 10:23
@ponceta ponceta added the fix Fixing something not working label Mar 13, 2024
@ponceta
Copy link
Member

ponceta commented Mar 26, 2024

Can you propose a variable settings to define used postgres and postgis values?

Because with the actual fix we would already have two versions used:

wastewater/plugin/teksi_wastewater/interlis/utils/various.py

Line 87 in 6cc3d8d

docker_image = os.getenv("TWWQWAT2ILI_TESTDB_IMAGE", "postgis/postgis:13-3.2")

If not required please just change the mentionned version to the same version as proposed.

ponceta
ponceta requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wastewater/plugin/teksi_wastewater/interlis/utils/various.py

Line 87 in 6cc3d8d

docker_image = os.getenv("TWWQWAT2ILI_TESTDB_IMAGE", "postgis/postgis:13-3.2")

@sjib
Copy link
Contributor

sjib commented Mar 26, 2024

QGEP/QGEP#821 (comment)

@3nids
Copy link
Contributor Author

3nids commented Mar 26, 2024

@domi4484 do you have an idea how to synchronize the docker image in the plugin?

@3nids
Copy link
Contributor Author

3nids commented Mar 27, 2024

good move @domi4484
@ponceta if it's ok for you, you can approve and merge

ponceta
ponceta approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proposed corrections

@ponceta ponceta closed this Apr 2, 2024
@ponceta ponceta reopened this Apr 2, 2024
@ponceta ponceta merged commit c53aab4 into main Apr 2, 2024
13 checks passed
@ponceta ponceta deleted the 3nids-patch-1 branch April 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

Assignees

@3nids 3nids

Labels
fix Fixing something not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current code is invalid with Postgis 3.2+
4 participants
@3nids @ponceta @sjib @domi4484