Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add psycopg2 support #198

Merged
merged 2 commits into from
Apr 9, 2024
Merged

add psycopg2 support #198

merged 2 commits into from
Apr 9, 2024

Conversation

3nids
Copy link
Contributor

@3nids 3nids commented Apr 9, 2024

I just realized that we probably don't have support for psycopg3 under certain environment for now (OSGeo4W at least).

So, we have to make the plugin compatible with psycopg2 at least.
We will leave the test to work on psycopg2 as it's the most critical environment.

@3nids 3nids requested a review from ponceta April 9, 2024 14:05
@ponceta
Copy link
Member

ponceta commented Apr 9, 2024

What tree do we have to shake to include psycopg (psycopg3) to future OSGeo4W versions?

@ponceta
Copy link
Member

ponceta commented Apr 9, 2024

https://trac.osgeo.org/osgeo4w/ticket/825#ticket opened an enhancement proposal here.

Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ponceta ponceta added enhancement New feature or request sustainability plugin Concerns the wastewater plugin labels Apr 9, 2024
@3nids 3nids merged commit 3581781 into main Apr 9, 2024
4 checks passed
@3nids 3nids deleted the psycopg2-support branch April 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Concerns the wastewater plugin sustainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants