Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 07 16 photo video for vsa kek testimport #316

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Jul 16, 2024

  • added inspectiondata folder with fotos and video (cut video to around 35 MB) to not conflict with github max 100 MB.
  • move that folder before publication of plugin @ponceta
  • changed prefix to ch20zzsh for KEK inspection datato have valid Swiss prefix

@sjib sjib self-assigned this Jul 16, 2024
@sjib sjib added enhancement New feature or request plugin Concerns the wastewater plugin labels Jul 16, 2024
@sjib sjib requested a review from ponceta July 16, 2024 14:34
@sjib sjib added this to the TEKSI Wastewater 2024.0 milestone Jul 16, 2024
@sjib
Copy link
Contributor Author

sjib commented Jul 16, 2024

@ponceta Here with the inspection data folder and a few more corrections. I have tested the import - it works

20240712_import_kek_adapt_path
On import you should adapt the path of the the inspectiondata folder to your local system.

It still needs some work with the file tab - see #272 (comment), but here is some KEK data so we are able to work on this. I try to comment in the issue on what I think would be needed there.

@ponceta
Copy link
Member

ponceta commented Jul 19, 2024

We have to host it somewhere so we don't have a plugin that weights 100mb

@domi4484 any experience with heavy media files accessibility?

Users should be able to download these easily.

@domi4484
Copy link
Contributor

@ponceta 100mb is a limitation of the QGIS plugin repository?

The pictures added here are pretty small and if with video the whole plugin stays by around 40mb I think there is no need to take them out of the package.

In the plugin we already do an on the fly download of Interlis binaries, and that would be possible for other data as well. Depending how "heavy" the files could still be hosted on github parallel to the plugin directory. Otherwise it would need some sort of other server/infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Concerns the wastewater plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants