Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/export wastewater structure symbols #355

Merged
merged 14 commits into from
Aug 8, 2024

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Aug 5, 2024

see #352

@sjib
Copy link
Contributor

sjib commented Aug 5, 2024

Thanks @cymed I think Abwasserbauwerk_Symbol we can support on import.
The *_text classes do not make to import, as they will change too quickly and will be re-created by TEKSI with a next change of the data anyway.

@sjib sjib added fix Fixing something not working INTERLIS About INTERLIS exchange format (import / export) labels Aug 5, 2024
@sjib sjib added this to the TEKSI Wastewater 2024.0 milestone Aug 5, 2024
@cymed cymed closed this Aug 7, 2024
@cymed cymed reopened this Aug 7, 2024
@ponceta ponceta closed this Aug 7, 2024
@ponceta ponceta reopened this Aug 7, 2024
@sjib
Copy link
Contributor

sjib commented Aug 7, 2024

E           AttributeError: 'abwasserbauwerk_symbol' object has no attribute 'letzte_aenderung'

teksi_wastewater/interlis/interlis_model_mapping/interlis_importer_to_intermediate_schema.py:2067: AttributeError

@sjib
Copy link
Contributor

sjib commented Aug 7, 2024

E               TypeError: 'symbol_scaling_height' is an invalid keyword argument for wastewater_structure_symbol

/usr/lib/python3/dist-packages/sqlalchemy/orm/decl_base.py:1197: TypeError

@cymed Da scheinen wir noch einen Übersetzungs- und Schreibfehler im Modell zu haben: symbol_scaling_height statt symbol_scaling_heigth

Das müsste ich im create script ändern

@sjib
Copy link
Contributor

sjib commented Aug 7, 2024

E           AttributeError: 'abwasserbauwerk_symbol' object has no attribute 'letzte_aenderung'

teksi_wastewater/interlis/interlis_model_mapping/interlis_importer_to_intermediate_schema.py:2067: AttributeError

@cymed I find wastewater_structure_symbol.last_modification in postgres - maybe also something I need to change. Dito for *_text.
Can you create a new issue for that if you agree?

@cymed
Copy link
Contributor Author

cymed commented Aug 7, 2024

E           AttributeError: 'abwasserbauwerk_symbol' object has no attribute 'letzte_aenderung'

teksi_wastewater/interlis/interlis_model_mapping/interlis_importer_to_intermediate_schema.py:2067: AttributeError

@cymed I find wastewater_structure_symbol.last_modification in postgres - maybe also something I need to change. Dito for *_text. Can you create a new issue for that if you agree?

I agree, they both do not inherit from SIA405_BaseClass

Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cymed looks good to me even if I cannot test right now.

Did you also adapt the export with wastewater_structure_symbol?

Else please open a new issue for that and we can do this separately.

@cymed cymed changed the title Import wastewater structure symbols Import/export wastewater structure symbols Aug 7, 2024
@sjib
Copy link
Contributor

sjib commented Aug 7, 2024

@cymed Nice - thanks!
@ponceta This pull request will also influence the data model!

@ponceta ponceta closed this Aug 8, 2024
@ponceta ponceta reopened this Aug 8, 2024
@ponceta ponceta merged commit 6f6a21b into teksi:main Aug 8, 2024
10 of 15 checks passed
@cymed cymed deleted the import-wastewater-structure-symbols branch August 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working INTERLIS About INTERLIS exchange format (import / export)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants