Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-08-07-unique-constraint-fk_1-fk_2-to-re_-tables #369

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Aug 7, 2024

Should solve #365

@sjib sjib marked this pull request as draft August 7, 2024 20:42
@sjib sjib self-assigned this Aug 7, 2024
@ponceta ponceta added the fix Fixing something not working label Aug 9, 2024
@ponceta
Copy link
Member

ponceta commented Aug 9, 2024

fk_building_group is not yet created, it has to be created before this additionnal statement otherwise it will fail as it is. (see docker logs in create dumps action to see the error)

https://github.com/teksi/wastewater/blob/f13c17a9919418ab49531d2bd97b5742fddf9cb1/datamodel/changelogs/0001/03_tww_db_dss.sql#L2966C58-L2966C76

@sjib sjib added this to the TEKSI Wastewater 2024.1 milestone Aug 9, 2024
@sjib sjib added the enhancement New feature or request label Aug 9, 2024
@sjib
Copy link
Contributor Author

sjib commented Aug 9, 2024

Needs #357 to be user friendly, else we will get a problem during import as duplicates will be blocked. This would be ok as long as we re-import the same re_table data, but makes it difficult if there are some new ones and some old one.

@sjib sjib requested a review from ponceta August 9, 2024 20:58
@sjib sjib marked this pull request as ready for review August 9, 2024 20:58
@sjib
Copy link
Contributor Author

sjib commented Aug 9, 2024

@ponceta l moved unique constraints to the end - now it looks ok

@sjib sjib requested a review from cymed August 9, 2024 21:10
@sjib
Copy link
Contributor Author

sjib commented Aug 9, 2024

@cymed also ok for you?

Copy link
Contributor

@domi4484 domi4484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ponceta ponceta merged commit 35c9eef into main Aug 12, 2024
7 checks passed
@ponceta ponceta deleted the 2024-08-07-unique-constraint-fk_1-fk_2-to-re_-tables branch August 12, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix Fixing something not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants