Create vw_tww_additional_wastewater_structure.

[cymed]

Tackles #38
Additional ws types for drainless_toilet, wwtp_structure and small_treatment_plant are handled separately to not blow up the main ws view. Also, no extra-cols are allowed.

[ponceta]

CI question :
Error: Process completed with exit code 137.
@3nids are there no failure logs in that case?

[3nids]

@ponceta I added the docker logs

to is a reserved keyword, I'd suggest using dt instead

[ponceta]

Thank you @3nids

This would be vw_tww_additional_wastewater_structure instead of vw_additional_wastewater_structure

(superclass views (superclass views that integrate all subclass attributes with prefixes to the attributes of the subclass) should be named vw_txx_superclass (example: vw_tww_maintenance_event). -> dev_guide_views)

[cymed]

I chose to because TO is the prefix of the OID-Postfix (ch000000TO000001)

[ponceta]

@cymed you can also use toi to avoid the postgreSQL limitation

[cymed]

@sjib can we change the shortcut_en of drainless_toilet from TO to DT? DT is not used and was not used in QGEP,
Also I suggest keeping a list of all shortcuts of former tables somewhere to avoid problems with oid uniqueness.

[3nids]

@cymed no need to change the shortcut in the OID, it's only the keyword in the SQL code of the view (you use to as shortname for the table)

[cymed]

@cymed no need to change the shortcut in the OID, it's only the keyword in the SQL code of the view (you use to as shortname for the table)

It is more user friendly to use the OID shortcut as alias

[ponceta]

On the datamodel side it seems now working but we have still to adapt something because they will appear as unkown ws_types in the current wastewater_structure layer and I think it is not expected to work like in that way (opposite is also true).

WHERE ch.obj_id IS NULL;

[cymed]

On the datamodel side it seems now working but we have still to adapt something because they will appear as unkown ws_types in the current wastewater_structure layer and I think it is not expected to work like in that way (opposite is also true).

WHERE ch.obj_id IS NULL;

As my other PR #36 also touches vw_tww_wastewater_structure I suggest I finish #36 first to not run into compatibility issues

Edit: #36 needs adapation on pirogue if the select is to be done dynamically, prioritising this PR

[sjib]

@sjib can we change the shortcut_en of drainless_toilet from TO to DT? DT is not used and was not used in QGEP, Also I suggest keeping a list of all shortcuts of former tables somewhere to avoid problems with oid uniqueness.

I will change from TO to DT in English, French and Italien and to TA in German as 'AT' is also a SQL Keyword

[sjib]

Are there other SQL keyword that we should avoid?

• 'AS'
• 'AT'
• 'TO'
• ???

[cymed]

even though that PR has the same % handling as vw_tww_wastewater_structure, this one throws an error

[3nids]

you need to switch the double %% to simple % (next to a pirogue update)

[cymed]

you need to switch the double %% to simple % (next to a pirogue update)

then why did da34826 not work?

[3nids]

because you have other remaining double %%

[cymed]

@ponceta ready for review

[ponceta]

Let's go with this as it will soon be an issue for anyone wanting to use the new classes in TWW.

This could lead to a .qgs project adaptation and a documentation specific for these new entities.