Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix re_building_group_disposal missing fk_columns #49

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix re_building_group_disposal missing fk_columns #49

merged 9 commits into from
Dec 12, 2023

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Dec 7, 2023 •
edited
Loading

Should fix the following issues:

@ponceta ponceta added datamodel Concerns the datamodel fix Fixing something not working labels Dec 8, 2023
sjib and others added 4 commits December 11, 2023 16:00
@sjib
20231211 changes master
fe20392
@sjib
id instead of obj_id in re_tables
9c4e1aa
@sjib
Shortcut drainless_toilett changed from TO to TA and description for …
c93659c 
…reach.elevation_determination adapted

Shortcut drainless_toilett changed from TO to TA and description for reach.elevation_determination adapte
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9f50a94 
for more information, see https://pre-commit.ci
@sjib sjib requested a review from 3nids December 11, 2023 15:13
@sjib sjib changed the title [WIP] re_building_group_disposal missing fk_columns fix re_building_group_disposal missing fk_columns Dec 11, 2023
@sjib
Copy link
Contributor Author

sjib commented Dec 11, 2023

@3nids Can you check on this
Run docker compose exec db init_db.sh wait time="2023-12-11T15:13:35Z" level=warning msg="The \"UID\" variable is not set. Defaulting to a blank string." time="2023-12-11T15:13:35Z" level=warning msg="The \"GID\" variable is not set. Defaulting to a blank string." waiting for postgres… 🐘 waiting for Postgres… 🐘 Error: Process completed with exit code 137.

@3nids
Copy link
Contributor

3nids commented Dec 12, 2023

Can we separate things?

This PR is to fix missing columns in the join tables but many views are added, could this be move to a separate PR if these changes are required (and if you create new join views, please create them with the python approach)

@sjib
Copy link
Contributor Author

sjib commented Dec 12, 2023 •
edited
Loading

many views are added

I integrated those view from master - I can try to kick them out again.

3nids
3nids reviewed Dec 12, 2023
View reviewed changes
datamodel/changelogs/0001/09_tww_dictionaries.sql
Comment on lines +6 to +13
DROP VIEW IF EXISTS tww_sys.dictionary_value_list;

CREATE VIEW tww_sys.dictionary_value_list AS
SELECT p.relname AS vl_name, vl.*
FROM tww_vl.value_list_base vl, pg_class p
WHERE vl.tableoid = p.oid;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be here

@3nids 3nids merged commit bbb3e91 into main Dec 12, 2023
4 checks passed
@sjib
Copy link
Contributor Author

sjib commented Dec 12, 2023

Thanks @3nids

sjib added a commit that referenced this pull request Dec 12, 2023
@sjib
09_tww_dictionaires.sql take out tww_sys.dictionary_value_list
f2ed9cf 
tww_sys.dictionary_value_list as requested in #49 (comment)
This was referenced Dec 12, 2023
Merged
Closed
@3nids 3nids deleted the 2023-12-07-re_building_group_disposal-fix branch January 19, 2024 09:09
cymed added a commit to cymed/TEKSI-wastewater that referenced this pull request Aug 14, 2024
@cymed
refresh knoten_bauwerksattribute (teksi#49)
8c584ed 
fixes teksi#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids 3nids left review comments

Assignees

@sjib sjib

Labels
datamodel Concerns the datamodel fix Fixing something not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjib @3nids @ponceta