Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Sharing Tasks and Pipelines without Copy Pasta #45

Closed
bobcatfish opened this issue Jun 13, 2019 · 12 comments
Closed

Design: Sharing Tasks and Pipelines without Copy Pasta #45

bobcatfish opened this issue Jun 13, 2019 · 12 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. maybe-next-milestone

Comments

@bobcatfish
Copy link
Contributor

bobcatfish commented Jun 13, 2019

Expected Behavior

We should have a recommended path for how we expect people to make use of the Tasks and Pipelines that we make available in this repo, as well as how they can share Tasks and Pipelines within a company.

We want to be able to uphold these attributes:

  • Config as code - i.e. checking in Pipelines and Tasks with the code they are used for (but what about a company with many repos that wants to share these? what about our official catalog?)
  • Updates to the definitions in this repo should be consumable for users (but how do we deal with changes and compatibility issues? should we have versions?)

Actual Behavior

At the moment the best way to use the Tasks and Pipelines in this repo would be to copy them (jokingly called "copy pasta") which would effectively fork them, meaning that copies can diverge over time.

image

Additional Info

One idea that might be worth exploring is using image registries (#29) to store Tasks and Pipelines as versioned artifacts. See https://stevelasker.blog/2019/01/25/cloud-native-artifact-stores-evolve-from-container-registries/.

@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. maybe-next-milestone labels Jun 13, 2019
@afrittoli
Copy link
Member

@xihaLong
Copy link

https://docs.google.com/document/d/1WbqPX4wmT1XLoJTM7gKekxLIUSZkggAcosYhR3lA6YQ/ Writing up a design document to capture some concrete ideas of how to potentially alleviate copy pasta, particularly focused on command line use by a Tekton end user. Open to edit by anyone in https://groups.google.com/forum/#!forum/tekton-dev and open to view publicly

@vdemeester
Copy link
Member

@popcor255
Copy link
Member

Maybe a tekton cli option is possible.
I starting writing a design doc. Here is a poc if anyone is interested.

I find the catalog really useful; however, I only apply the task once. I dont think having a dedicated api is a real solution. However, I think having cli implementation is low hanging fruit.

1) tkapply() { kubectl get -f $1 -o json | http https://tekton-catalog-api.netlify.app/.netlify/functions/api/get/tasks | kubectl apply -f - }

2) tkapply <file>

@bobcatfish
Copy link
Contributor Author

bobcatfish commented Jul 23, 2020

Related work that is also related is around the OCI image registry, and task versioning, see tektoncd/pipeline#1839 and tektoncd/community#137 (OCI TEP)

@bobcatfish
Copy link
Contributor Author

Config as code - i.e. checking in Pipelines and Tasks with the code they are used for (but what about a company with many repos that wants to share these? what about our official catalog?)

And on this issue, also see tektoncd/pipeline#859

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2020
@bobcatfish
Copy link
Contributor Author

It seems to me like this issue will be solved by @pierretasci's work in tektoncd/pipeline#1839, which will allow referencing Tasks and Pipelines in image registries, and opens the door to referencing other locations (e.g. git repos) as well.

Seems reasonable to me to close this issue? (@vdemeester @popcor255 )

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 20, 2020
@popcor255
Copy link
Member

/close

@tekton-robot
Copy link

@popcor255: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@popcor255
Copy link
Member

Closing since #2395 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. maybe-next-milestone
Projects
None yet
Development

No branches or pull requests

6 participants