Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing maven/0.3 test fail due to more that one PVC is bound #1187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions task/maven/0.3/maven.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ spec:
description: >-
The workspace consisting of the custom maven settings
provided by the user.
- name: maven-local-repo
description: Local repo (m2) workspace
optional: true
params:
- name: MAVEN_IMAGE
type: string
Expand Down Expand Up @@ -151,4 +148,4 @@ spec:
- -s
- $(workspaces.maven-settings.path)/settings.xml
- "$(params.GOALS)"
- '-Dmaven.repo.local=$(workspaces.maven-local-repo.path)/.m2'
- '-Dmaven.repo.local=$(workspaces.maven-settings.path)/.m2'
11 changes: 0 additions & 11 deletions task/maven/0.3/tests/resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,6 @@ apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: maven-source-pvc
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 500Mi
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: maven-local-m2-pvc
spec:
accessModes:
- ReadWriteOnce
Expand Down
8 changes: 0 additions & 8 deletions task/maven/0.3/tests/run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ spec:
workspaces:
- name: shared-workspace
- name: maven-settings
- name: maven-local-m2
tasks:
- name: fetch-repository
taskRef:
Expand Down Expand Up @@ -40,8 +39,6 @@ spec:
workspace: maven-settings
- name: source
workspace: shared-workspace
- name: maven-local-repo
workspace: maven-local-m2
- name: maven-run-build-2
taskRef:
name: maven
Expand All @@ -60,8 +57,6 @@ spec:
workspace: maven-settings
- name: source
workspace: shared-workspace
- name: maven-local-repo
workspace: maven-local-m2
---
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
Expand All @@ -76,6 +71,3 @@ spec:
- name: shared-workspace
persistentvolumeclaim:
claimName: maven-source-pvc
- name: maven-local-m2
persistentvolumeclaim:
claimName: maven-local-m2-pvc