Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jib-gradle task #199

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix jib-gradle task #199

merged 1 commit into from
Feb 27, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Feb 27, 2020

This wil fix the issue jib gradle task
gettng failed on security constrained
environments like OpenShift

Fix #198

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

This wil fix the issue jib gradle task
gettng failed on security constrained
environments like OpenShift

Fix tektoncd#198
@tekton-robot tekton-robot requested review from a user and vdemeester February 27, 2020 14:17
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2020
Copy link
Member

@hrishin hrishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@piyush-garg
Copy link
Contributor Author

/test pull-tekton-catalog-integration-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrishin, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@tekton-robot tekton-robot merged commit 21cb87f into tektoncd:master Feb 27, 2020
@loosebazooka
Copy link
Contributor

loosebazooka commented Feb 28, 2020

@piyush-garg I can't see how this actually helps. The gradle home is already defined using the system property: https://github.com/tektoncd/catalog/pull/199/files#diff-218c88f355db45e8a7a0e2bc9e76ac0eR48

Can you provide an explanation as to how this works? and why it's necessary? Is ~/.gradle not an appropriate home path?

gradle-user-home seems rather arbitrary, is it a constraint of the base image you're using?

@chanseokoh
Copy link
Contributor

And this actually breaks caching. I don't think this is the right fix. We should revert it.

    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.gradle/caches
      subPath: gradle-caches
    - name: $(inputs.params.CACHE)
      mountPath: /tekton/home/.gradle/wrapper

@loosebazooka
Copy link
Contributor

loosebazooka commented Feb 28, 2020

This comment: gradle/gradle#8107 (comment) seems to indicate that it's a problem with the permissions of the .gradle directory. The solution in that comment is meant to diagnose the problem, not as a permanent solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jib-gradle not working on OpenShift
6 participants