Add fixes for tasks as per latest pipelines 0.24+ #763

vinamra28 · 2021-06-22T17:02:35Z

Changes

With pipelines version 0.24.x+ HOME and default workingDir would not be set by
default and because of this some tasks in the catalog are failing. The following PR fixes
those tasks. The following tasks are changed:

ansible-runner
buildpacks-phases
git-clone
orka-deploy
orka-full

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Follows the authoring recommendations
Includes docs (if user facing)
Includes tests (if functionality of task changed or new task added)
Commit messages follow commit message best practices
Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
- File path follows <kind>/<name>/<version>/name.yaml
- Has README.md at <kind>/<name>/<version>/README.md
- Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource
- Has mandatory metadata.annotations tekton.dev/pipelines.minVersion
- mandatory spec.description follows the convention
```
  ```
  
    spec:
      description: >-
        one line summary of the resource
  
        Paragraph(s) to describe the resource.
  ```
```

See the contribution guide
for more details.

vinamra28 · 2021-06-22T17:02:42Z

Adding a hold so that I can check other tasks as well for the failure after we bump the version of pipelines 0.25
/hold

tekton-robot · 2021-06-22T17:04:46Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env

tekton-robot · 2021-06-22T17:35:50Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml
FILE: task/buildpacks-phases/0.1/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.2/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "analyze" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "restore" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "export" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-prepare line 33:
    IFS='=' read -r key value string <<< "$env"
                              ^----^ SC2034: string appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- string appears unused. Verify use...

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-results line 3:
cat /layers/report.toml | grep "digest" | cut -d'"' -f2 | cut -d'"' -f2 | tr -d '\n' | tee $(results.APP_IMAGE_DIGEST.path)
    ^-----------------^ SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                                           ^-- SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

tekton-robot · 2021-06-23T02:47:46Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml
FILE: task/argocd-task-sync-and-wait/0.1/argocd-task-sync-and-wait.yaml
WARN : Step "login" uses image "docker.io/argoproj/argocd:$(params.argocd-version)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.1/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.2/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "analyze" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "restore" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "export" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
FILE: task/git-clone/0.1/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/github-open-pr/0.1/github-open-pr.yaml

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-prepare line 33:
    IFS='=' read -r key value string <<< "$env"
                              ^----^ SC2034: string appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- string appears unused. Verify use...

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-results line 3:
cat /layers/report.toml | grep "digest" | cut -d'"' -f2 | cut -d'"' -f2 | tr -d '\n' | tee $(results.APP_IMAGE_DIGEST.path)
    ^-----------------^ SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                                           ^-- SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115: Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 19:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 35:
cd "$CHECKOUT_DIR"
^----------------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd "$CHECKOUT_DIR" || exit


In git-clone-clone line 43:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC2039: In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, [[ ]] is undefined.
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

WARN : step: github-open-pr is not using #!/usr/bin/env

tekton-robot · 2021-06-23T04:11:06Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml
FILE: task/buildpacks-phases/0.1/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.2/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "analyze" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "restore" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "export" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
FILE: task/git-clone/0.1/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/orka-deploy/0.1/orka-deploy.yaml

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-prepare line 33:
    IFS='=' read -r key value string <<< "$env"
                              ^----^ SC2034: string appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- string appears unused. Verify use...

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-results line 3:
cat /layers/report.toml | grep "digest" | cut -d'"' -f2 | cut -d'"' -f2 | tr -d '\n' | tee $(results.APP_IMAGE_DIGEST.path)
    ^-----------------^ SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                                           ^-- SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115: Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 19:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 35:
cd "$CHECKOUT_DIR"
^----------------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd "$CHECKOUT_DIR" || exit


In git-clone-clone line 43:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC2039: In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, [[ ]] is undefined.
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

WARN : step: orka-deploy is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In orka-deploy-copy-script line 4:
cat > $SCRIPT << 'EOF'
      ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cat > "$SCRIPT" << 'EOF'


In orka-deploy-copy-script line 7:
copy-script $SCRIPT
            ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
copy-script "$SCRIPT"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

WARN : step: orka-deploy is not using #!/usr/bin/env

tekton-robot · 2021-06-23T05:08:57Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml
FILE: task/buildpacks-phases/0.1/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.2/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "analyze" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "restore" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "export" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
FILE: task/git-clone/0.1/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/orka-deploy/0.1/orka-deploy.yaml
FILE: task/orka-full/0.1/orka-full.yaml
HINT : Task: tekton.dev/v1beta1 - name: "orka-full" is missing a readable display name annotation("tekton.dev/displayName")
HINT : Task: tekton.dev/v1beta1 - name: "orka-full" is easily discoverable if it has annotation for tag "tekton.dev/tags"

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-prepare line 33:
    IFS='=' read -r key value string <<< "$env"
                              ^----^ SC2034: string appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- string appears unused. Verify use...

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-results line 3:
cat /layers/report.toml | grep "digest" | cut -d'"' -f2 | cut -d'"' -f2 | tr -d '\n' | tee $(results.APP_IMAGE_DIGEST.path)
    ^-----------------^ SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                                           ^-- SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115: Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 19:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 35:
cd "$CHECKOUT_DIR"
^----------------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd "$CHECKOUT_DIR" || exit


In git-clone-clone line 43:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC2039: In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, [[ ]] is undefined.
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

WARN : step: orka-deploy is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In orka-deploy-copy-script line 4:
cat > $SCRIPT << 'EOF'
      ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cat > "$SCRIPT" << 'EOF'


In orka-deploy-copy-script line 7:
copy-script $SCRIPT
            ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
copy-script "$SCRIPT"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

WARN : step: orka-deploy is not using #!/usr/bin/env 
WARN : step: orka-full is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In orka-full-copy-script line 4:
cat > $SCRIPT << 'EOF'
      ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cat > "$SCRIPT" << 'EOF'


In orka-full-copy-script line 7:
copy-script $SCRIPT
            ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
copy-script "$SCRIPT"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` Signed-off-by: vinamra28 <[email protected]>

git-clone 0.1: Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` git-clone 0.4: Changed the default value of userHome param from `/root` to `/tekton/home` as it was not matching the README. Signed-off-by: vinamra28 <[email protected]>

Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home`. Also set the default `workingDir` as `/workspace`. Signed-off-by: vinamra28 <[email protected]>

tekton-robot · 2021-06-23T06:20:25Z

Catlin Output

FILE: task/ansible-runner/0.1/ansible-runner.yaml
FILE: task/buildpacks-phases/0.1/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
FILE: task/buildpacks-phases/0.2/buildpacks-phases.yaml
WARN : Step "copy-stack-toml" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "detect" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "analyze" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "restore" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
WARN : Step "build" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "export" uses image "$(params.LIFECYCLE_IMAGE)" that contains variables; skipping validation
FILE: task/git-clone/0.1/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/git-clone/0.4/git-clone.yaml
WARN : Step "clone" uses image "$(params.gitInitImage)" that contains variables; skipping validation
FILE: task/orka-deploy/0.1/orka-deploy.yaml
FILE: task/orka-full/0.1/orka-full.yaml
HINT : Task: tekton.dev/v1beta1 - name: "orka-full" is missing a readable display name annotation("tekton.dev/displayName")
HINT : Task: tekton.dev/v1beta1 - name: "orka-full" is easily discoverable if it has annotation for tag "tekton.dev/tags"

Catlin script lint Output

WARN : step: ansible-runner is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-prepare line 33:
    IFS='=' read -r key value string <<< "$env"
                              ^----^ SC2034: string appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- string appears unused. Verify use...

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In buildpacks-phases-results line 3:
cat /layers/report.toml | grep "digest" | cut -d'"' -f2 | cut -d'"' -f2 | tr -d '\n' | tee $(results.APP_IMAGE_DIGEST.path)
    ^-----------------^ SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
                                                                                           ^-- SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In git-clone-clone line 9:
  if [[ -d "$CHECKOUT_DIR" ]] ; then
     ^----------------------^ SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 11:
    rm -rf "$CHECKOUT_DIR"/*
           ^---------------^ SC2115: Use "${var:?}" to ensure this never expands to /* .


In git-clone-clone line 19:
if [[ "${PARAM_DELETE_EXISTING}" == "true" ]] ; then
   ^-- SC2039: In POSIX sh, [[ ]] is undefined.


In git-clone-clone line 35:
cd "$CHECKOUT_DIR"
^----------------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd "$CHECKOUT_DIR" || exit


In git-clone-clone line 43:
echo -n "$RESULT_SHA" > $(results.commit.path)
     ^-- SC2039: In POSIX sh, echo flags are undefined.
                        ^--------------------^ SC2046: Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, [[ ]] is undefined.
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...

WARN : step: orka-deploy is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In orka-deploy-copy-script line 4:
cat > $SCRIPT << 'EOF'
      ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cat > "$SCRIPT" << 'EOF'


In orka-deploy-copy-script line 7:
copy-script $SCRIPT
            ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
copy-script "$SCRIPT"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

WARN : step: orka-deploy is not using #!/usr/bin/env 
WARN : step: orka-full is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In orka-full-copy-script line 4:
cat > $SCRIPT << 'EOF'
      ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cat > "$SCRIPT" << 'EOF'


In orka-full-copy-script line 7:
copy-script $SCRIPT
            ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
copy-script "$SCRIPT"

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

vinamra28 · 2021-06-23T06:31:11Z

/hold cancel
/cc @chmouel @sbwsg @vdemeester

vdemeester

/cc @sbwsg

chmouel · 2021-06-23T07:57:57Z

Nice one !

/lgtm
/approve

tekton-robot · 2021-06-23T07:58:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chmouel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from dlorenc and a user June 22, 2021 17:02

tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021

vinamra28 force-pushed the fix-tasks-for-latest branch from 0db23d4 to adcfc64 Compare June 23, 2021 04:08

vinamra28 force-pushed the fix-tasks-for-latest branch from adcfc64 to 93fdc5c Compare June 23, 2021 05:07

vinamra28 added 4 commits June 23, 2021 11:39

Fix ansible runner task as per pipelines 0.24+

cb070b4

Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` Signed-off-by: vinamra28 <[email protected]>

Fix buildapacks-phases task as per pipelines 0.24+

0f7a5c7

Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` Signed-off-by: vinamra28 <[email protected]>

Fix orka-* task as per pipelines 0.24+

460c57f

Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home`. Also set the default `workingDir` as `/workspace`. Signed-off-by: vinamra28 <[email protected]>

vinamra28 force-pushed the fix-tasks-for-latest branch from 93fdc5c to 460c57f Compare June 23, 2021 06:19

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2021

tekton-robot requested review from chmouel and vdemeester June 23, 2021 06:31

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021

vdemeester approved these changes Jun 23, 2021

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021

tekton-robot assigned chmouel Jun 23, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021

tekton-robot merged commit d4798eb into tektoncd:main Jun 23, 2021

vinamra28 deleted the fix-tasks-for-latest branch June 23, 2021 08:20

vdemeester mentioned this pull request Jul 1, 2021

Update git-clone 0.4 task for 1.5.0 tektoncd/operator#342

Merged

3 tasks

bobcatfish mentioned this pull request Jul 19, 2021

Update policy to bump Task/Pipeline versions whenever a change is made #784

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fixes for tasks as per latest pipelines 0.24+ #763

Add fixes for tasks as per latest pipelines 0.24+ #763

vinamra28 commented Jun 22, 2021 •

edited

Loading

vinamra28 commented Jun 22, 2021 •

edited

Loading

tekton-robot commented Jun 22, 2021

tekton-robot commented Jun 22, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

vinamra28 commented Jun 23, 2021

vdemeester left a comment

chmouel commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

Add fixes for tasks as per latest pipelines 0.24+ #763

Add fixes for tasks as per latest pipelines 0.24+ #763

Conversation

vinamra28 commented Jun 22, 2021 • edited Loading

Changes

Submitter Checklist

vinamra28 commented Jun 22, 2021 • edited Loading

tekton-robot commented Jun 22, 2021

tekton-robot commented Jun 22, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

vinamra28 commented Jun 23, 2021

vdemeester left a comment

Choose a reason for hiding this comment

chmouel commented Jun 23, 2021

tekton-robot commented Jun 23, 2021

vinamra28 commented Jun 22, 2021 •

edited

Loading

vinamra28 commented Jun 22, 2021 •

edited

Loading