-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixes for tasks as per latest pipelines 0.24+ #763
Conversation
Adding a hold so that I can check other tasks as well for the failure after we bump the version of pipelines 0.25 |
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
Catlin Output
Catlin script lint Output
|
0db23d4
to
adcfc64
Compare
Catlin Output
Catlin script lint Output
|
adcfc64
to
93fdc5c
Compare
Catlin Output
Catlin script lint Output
|
Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` Signed-off-by: vinamra28 <[email protected]>
Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` Signed-off-by: vinamra28 <[email protected]>
git-clone 0.1: Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home` git-clone 0.4: Changed the default value of userHome param from `/root` to `/tekton/home` as it was not matching the README. Signed-off-by: vinamra28 <[email protected]>
Add a parameter through which we can set the `HOME` env variable which if not provided will default to `/tekton/home`. Also set the default `workingDir` as `/workspace`. Signed-off-by: vinamra28 <[email protected]>
93fdc5c
to
460c57f
Compare
Catlin Output
Catlin script lint Output
|
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @sbwsg
Nice one ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
With pipelines version 0.24.x+
HOME
and default workingDir would not be set bydefault and because of this some tasks in the catalog are failing. The following PR fixes
those tasks. The following tasks are changed:
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.