Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoticons and colors are not displaying properly on Windows #914

Closed
VeereshAradhya opened this issue Apr 20, 2020 · 9 comments · Fixed by #919
Closed

Emoticons and colors are not displaying properly on Windows #914

VeereshAradhya opened this issue Apr 20, 2020 · 9 comments · Fixed by #919
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@VeereshAradhya
Copy link
Contributor

VeereshAradhya commented Apr 20, 2020

Version and Operating System

tkn Version:
Latest dev

Operating System:
Microsoft Windows-10 Enterprise(10.0.15063)

Expected Behavior

Emoticons and colors should display properly on Windows-10 machine

Actual Behavior

Emoticons and colors are not getting displayed properly on Windows-10 machine

Steps to Reproduce the Problem

  1. Create and start a task using tkn task start command
  2. List the tasks using the command tkn task ls and observe the STATUS field
  3. Describe the task using the command tkn task describe and observe the output

#Note:

  1. The output for list and describe command looks fine when we use -C option

Additional Info

Screenshots for the output of list and describe are below
Screenshot from 2020-04-20 09-17-04

Screenshot from 2020-04-20 10-39-52

Tested with powershell, the emoticons in describe are not getting displayed properly but output of tkn tr ls looks fine
Screenshot from 2020-04-20 16-47-55

@piyush-garg
Copy link
Contributor

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 20, 2020
@chmouel
Copy link
Member

chmouel commented Apr 20, 2020

We probably should disable it if we are on windows

@VeereshAradhya
Copy link
Contributor Author

Tested with powershell and updated the description

@ppitonak
Copy link
Contributor

We probably should disable it if we are on windows

IMHO there should be a CLI switch for disabling it explicitly (+ disable by default on Win) because sometimes you don't want emoticons and color when exporting logs to external systems.

@chmouel
Copy link
Member

chmouel commented Apr 20, 2020

if you do --nocolour it will disable emoticon as well....

And even tho if you do a redirection (i.e: not terminal stty) to a file the emoticons and colours will be disabled by default....

@chmouel
Copy link
Member

chmouel commented Apr 21, 2020

@VeereshAradhya is it something you can do ? As I don't have a windows machine, I won't be able to fix it (but i can disable it if we run on windows)

@chmouel
Copy link
Member

chmouel commented Apr 21, 2020

/assign

chmouel added a commit to chmouel/tektoncd-cli that referenced this issue Apr 21, 2020
@chmouel
Copy link
Member

chmouel commented Apr 21, 2020

@VeereshAradhya can you test https://drive.google.com/open?id=1IWYIMlwqTr4tCLiUAcTmB245h72-dM9d please ?

thanks!

@VeereshAradhya
Copy link
Contributor Author

Tested the executable given by @chmouel . Both color and emoticons are disabled
Command Prompt:
Screenshot from 2020-04-21 14-22-23

Powershell
Screenshot from 2020-04-21 14-25-00

tekton-robot pushed a commit that referenced this issue Apr 21, 2020
Fixes #914, #915

Signed-off-by: Chmouel Boudjnah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants