-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoticons and colors are not displaying properly on Windows #914
Comments
/kind bug |
We probably should disable it if we are on windows |
Tested with powershell and updated the description |
IMHO there should be a CLI switch for disabling it explicitly (+ disable by default on Win) because sometimes you don't want emoticons and color when exporting logs to external systems. |
if you do And even tho if you do a redirection (i.e: not terminal stty) to a file the emoticons and colours will be disabled by default.... |
@VeereshAradhya is it something you can do ? As I don't have a windows machine, I won't be able to fix it (but i can disable it if we run on windows) |
/assign |
Fixes tektoncd#914, tektoncd#915 Signed-off-by: Chmouel Boudjnah <[email protected]>
@VeereshAradhya can you test https://drive.google.com/open?id=1IWYIMlwqTr4tCLiUAcTmB245h72-dM9d please ? thanks! |
Tested the executable given by @chmouel . Both color and emoticons are disabled |
Fixes #914, #915 Signed-off-by: Chmouel Boudjnah <[email protected]>
Version and Operating System
tkn Version:
Latest dev
Operating System:
Microsoft Windows-10 Enterprise(10.0.15063)
Expected Behavior
Emoticons and colors should display properly on Windows-10 machine
Actual Behavior
Emoticons and colors are not getting displayed properly on Windows-10 machine
Steps to Reproduce the Problem
tkn task start
commandtkn task ls
and observe theSTATUS
fieldtkn task describe
and observe the output#Note:
list
anddescribe
command looks fine when we use-C
optionAdditional Info
Screenshots for the output of
list
anddescribe
are belowTested with powershell, the emoticons in
describe
are not getting displayed properly but output oftkn tr ls
looks fineThe text was updated successfully, but these errors were encountered: