Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting TaskRun Describe Tests to Use Test Builder Methods for StepState #552

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Converting TaskRun Describe Tests to Use Test Builder Methods for StepState #552

merged 1 commit into from
Dec 27, 2019

Conversation

danielhelfand
Copy link
Member

I added test builder methods for step state in this pull request to pipeline. These methods have been available since pipeline 0.9.0, so I am now updating the taskrun describe unit tests to make use of these additions.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

N/A

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 26, 2019
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2019
pradeepitm12
pradeepitm12 approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

@tekton-robot tekton-robot merged commit 2dd2d44 into tektoncd:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielhelfand @tekton-robot @piyush-garg @pradeepitm12 @googlebot