Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0104] Update Step-level Validation Cases #763

Closed
wants to merge 1 commit into from

Conversation

austinzhao-go
Copy link
Contributor

@austinzhao-go austinzhao-go commented Jul 25, 2022

This update clarifies the validation cases for step-level resource requirements which were discussed from thread

The related TEP:
TEP-0104: Task-level Resource Requirements
tektoncd/pipeline#5082 (comment)

This update clarifies the validation cases for step-level resource requirements.
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign afrittoli after the PR has been reviewed.
You can assign the PR to them by writing /assign @afrittoli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2022
@austinzhao-go
Copy link
Contributor Author

/assign @lbernick

@austinzhao-go
Copy link
Contributor Author

closed as the current TEP should be able to explain the cases - so the step-level resource requirements will not be taken if task-level was configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants