-
Notifications
You must be signed in to change notification settings - Fork 265
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add client-side pagination to all list pages via the `ListPageLayout` container. Update the `children` prop to expect a function so we can use the render props pattern to allow the `ListPageLayout` component to handle all of the pagination logic required. Consuming pages pass their raw resources to `ListPageLayout` and it passes back the correct slice for the current pagination settings which the consumer then formats / renders as needed. Although we're still loading and storing the full list of resources from the API this does have significant performance benefits in the client, especially with larger number of resources. Notably, this addresses freezing reported by a number of users on the PipelineRuns and TaskRuns pages with busy clusters.
- Loading branch information
1 parent
f86bf57
commit 14cce74
Showing
29 changed files
with
1,015 additions
and
794 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.