Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support TEP-0100: Embedded TaskRuns and Runs Status in PipelineRuns #2340

Closed
4 tasks
AlanGreene opened this issue Apr 20, 2022 · 2 comments
Closed
4 tasks
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@AlanGreene
Copy link
Member

TEP-0100 proposes changes to PipelineRun Status to reduce the amount of information stored about the status of TaskRuns and Runs to improve performance, reduce memory bloat and improve extensibility. See tektoncd/pipeline#3140 and the TEP for background information, details on motivation, and implementation.

The Dashboard currently uses PipelineRun.status.taskRuns in a number of places, but once the embedded-status flag is switched to minimal (will be default ~9 months from now) the Dashboard will no longer be able to use this data and will have to retrieve it by other means / from other sources.

Users can opt in to this new behaviour at any point so the Dashboard should be updated soon to start adding support, or at least ensuring it doesn't completely break the UI.

TODO

  • Identify places the Dashboard currently uses PipelineRun.status.taskRuns
    • Some of these are currently used as a fallback if the TaskRun resource has been deleted from the cluster and shouldn't cause any issues
  • Identify the remaining uses that need attention, e.g. warning StatusIcon on PipelineRuns page
  • Update code to retrieve the required data from other sources or remove the affected functionality
    • What is the impact of removing any affected functionality? Are there alternatives?

NOTE

We should review this in more detail once the PIpelineRuns page design updates are implemented (finalising design 2022/04 and implementing in early 2022/05) as that may simplify (or potentially remove) some of the currently affected code.

@AlanGreene AlanGreene added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2022
@abayer
Copy link

abayer commented Jun 23, 2022

This is a dependency of tektoncd/pipeline#4954.

The new embedded-status feature flag, with full as the default value, is in Pipeline v0.35.0 and later.

@AlanGreene
Copy link
Member Author

This is done and has been included in nightly builds for about a week. It will be included in the next Dashboard release (v0.28.0) next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants