Update PipelineRun and PipelineRuns components to support minimal status (TEP-0100) #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tus (TEP-0100) Update logic in the PipelineRun components that relied on `PipelineRun.status.taskRuns` and include checks for the new `childReferences` field. There may be additional changes required but these are the minimum I identified to ensure the UI doesn't fall over or end up in an inconsistent state when the `embedded-status` feature flag is set to `minimal` Fix graph components so the stories render. These will be largely replaced in future so it's just a quick fix so the storybook builds successfully.
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2340
Update logic in the PipelineRun components that relied on
PipelineRun.status.taskRunsand include checks for the new
childReferencesfield. There may be additional changesrequired but these are the minimum I identified to ensure the UI doesn't fall over or
end up in an inconsistent state when the
embedded-statusfeature flag is set tominimalFix graph components so the stories render. These will be largely replaced in future so
it's just a quick fix so the storybook builds successfully.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.