Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release pipeline to use results and workspaces instead of PipelineResources #2232

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

AlanGreene
Copy link
Member

Changes

#1969

PipelineResources are deprecated and we're currently moving our existing automation
to the new patter, using workspaces and results instead of PipelineResources.

Follow the same general structure and layout as the current tektoncd/pipeline
release pipeline with some minor changes for the Dashboard-specific pieces:

  • use a custom build task to build the UI bundles (update to latest Node 14.x)
  • we produce multiple additional YAML release manifests (OpenShift, read-only)

Update documentation to reflect the new structure and approach, again heavily
based on the documentation for the tektoncd/pipeline release resources.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2021
@AlanGreene
Copy link
Member Author

yamllint… copying config from tektoncd/pipeline, hopefully that'll resolve most issues

@AlanGreene AlanGreene force-pushed the release_pipeline branch 2 times, most recently from 8750631 to f991c58 Compare November 8, 2021 18:44
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 8, 2021
@AlanGreene AlanGreene force-pushed the release_pipeline branch 3 times, most recently from c375d0f to 9ae3954 Compare November 9, 2021 10:32
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
…lineResources

PipelineResources are deprecated and we're currently moving our existing automation
to the new patter, using workspaces and results instead of PipelineResources.

Follow the same general structure and layout as the current tektoncd/pipeline
release pipeline with some minor changes for the Dashboard-specific pieces:
- use a custom build task to build the UI bundles (update to latest Node 14.x)
- silence noisy packages on install (CI=true)
- we produce multiple additional YAML release manifests (OpenShift, read-only)

Update documentation to reflect the new structure and approach, again heavily
based on the documentation for the tektoncd/pipeline release resources.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@AlanGreene AlanGreene marked this pull request as ready for review November 10, 2021 11:04
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@AlanGreene AlanGreene removed the request for review from ziheng November 10, 2021 11:04
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@tekton-robot tekton-robot merged commit 95831e7 into tektoncd:main Nov 10, 2021
@AlanGreene AlanGreene deleted the release_pipeline branch November 10, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants