Improve and simplify webpack build #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we use consistent hashing method for vendor bundle to avoid unnecessary rebuilds. Remove the `build_ko` npm script as we no longer need to support two different locations for the build output. This was leftover from some very early releases of the Dashboard. The webpack build output should always be placed in the `kodata` folder. Update docs to reflect the change.
tekton-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
AlanGreene
added a commit
to AlanGreene/dashboard
that referenced
this pull request
May 11, 2022
We removed the dist folder in tektoncd#2277 but missed a few references. Remove these and fix the `build:analyze` script to point at the correct location for the webpack build output.
4 tasks
AlanGreene
added a commit
to AlanGreene/dashboard
that referenced
this pull request
May 11, 2022
We removed the dist folder in tektoncd#2277 but missed a few references. Remove these and fix the `build:analyze` script to point at the correct location for the webpack build output.
tekton-robot
pushed a commit
that referenced
this pull request
May 12, 2022
We removed the dist folder in #2277 but missed a few references. Remove these and fix the `build:analyze` script to point at the correct location for the webpack build output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensure we use consistent hashing method for vendor bundle to avoid
unnecessary rebuilds.
Remove the
build_konpm script as we no longer need to support twodifferent locations for the build output. This was leftover from
some very early releases of the Dashboard. The webpack build output
should always be placed in the
kodatafolder. Update docs to reflectthe change.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.