Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused font formats from config #2284

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

AlanGreene
Copy link
Member

Changes

Update Jest and webpack config to remove unused font formats.

The only font loaded in the Dashboard is IBM Plex (via Carbon),
and Carbon only uses the woff and woff2 formats.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

Update Jest and webpack config to remove unused font formats.

The only font loaded in the Dashboard is IBM Plex (via Carbon),
and Carbon only uses the woff and woff2 formats.
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2022
@AlanGreene AlanGreene removed the request for review from steveodonovan January 14, 2022 16:07
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@AlanGreene
Copy link
Member Author

npm install failed, unrelated to our code or the change in this PR
/test pull-tekton-dashboard-integration-tests

@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

@AlanGreene AlanGreene mentioned this pull request Jan 19, 2022
4 tasks
@tekton-robot tekton-robot merged commit 1ed9496 into tektoncd:main Jan 19, 2022
@AlanGreene AlanGreene deleted the fonts branch January 19, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants