Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow clusterrole to use psp tekton-pipelines #2302

Closed
wants to merge 1 commit into from
Closed

allow clusterrole to use psp tekton-pipelines #2302

wants to merge 1 commit into from

Conversation

psychosis448
Copy link

Changes

Currently the dashboard pods can not be deployed due to missing capability of the tekton-dashboard-tenant clusterrole to use the tekton-pipelines psp.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign alangreene
You can assign the PR to them by writing /assign @alangreene in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Contributor

Hi @psychosis448. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 27, 2022
@psychosis448
Copy link
Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2022
@AlanGreene
Copy link
Member

Thanks for the PR @psychosis448, however this is not something we're going to merge.

PodSecurityPolicy was deprecated almost a year ago and will be removed from Kubernetes later this year.
From https://kubernetes.io/docs/concepts/policy/pod-security-policy/

PodSecurityPolicy is deprecated as of Kubernetes v1.21 and will be removed in v1.25

Also see the issue in tektoncd/pipeline discussing the deprecation tektoncd/pipeline#4112
and the corresponding PR tektoncd/pipeline#4122 which also discusses the plan to migrate to Pod Security Admission.

If patching the tekton-dashboard-tenant ClusterRole works for your use case I would suggest you continue doing that until the replacement approach is ready for use.

@AlanGreene AlanGreene closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants