-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design of runs pages #2356
Conversation
/test pull-tekton-dashboard-unit-tests |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and cheers for the walkthrough
Couple of minor questions, but otherwise good to go
Update the table layout used for the PipelineRuns and TaskRuns pages to include more useful information such as trigger info, status details, and combine fields where this makes sense (e.g. created time + duration).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Update the table layout used for the PipelineRuns and TaskRuns pages
to include more useful information such as trigger info, status details,
and combine fields where this makes sense (e.g. created time + duration).
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.