Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design of runs pages #2356

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

AlanGreene
Copy link
Member

Changes

Update the table layout used for the PipelineRuns and TaskRuns pages
to include more useful information such as trigger info, status details,
and combine fields where this makes sense (e.g. created time + duration).

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 10, 2022
@AlanGreene AlanGreene marked this pull request as draft May 10, 2022 14:31
@AlanGreene AlanGreene removed the request for review from skaegi May 10, 2022 14:31
@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-unit-tests

@AlanGreene
Copy link
Member Author

/retest

@AlanGreene AlanGreene marked this pull request as ready for review May 12, 2022 11:27
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and cheers for the walkthrough

Couple of minor questions, but otherwise good to go

Update the table layout used for the PipelineRuns and TaskRuns pages
to include more useful information such as trigger info, status details,
and combine fields where this makes sense (e.g. created time + duration).
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@tekton-robot tekton-robot merged commit 1e0ee7b into tektoncd:main May 13, 2022
@AlanGreene AlanGreene deleted the runs_design branch May 13, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants