Handle invalid params in Task spec #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we somehow get `params: null`, ensure the UI handles this gracefully and doesn't fall over. The previous code would fail in this case as the default value was only used if `params` was `undefined`. Update the code to use the default for all falsy values.
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/M
tekton-robot
removed
the
do-not-merge/work-in-progress
LyndseyBu
approved these changes
May 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LyndseyBu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If we somehow get
params: null, ensure the UI handles this gracefullyand doesn't fall over. The previous code would fail in this case as
the default value was only used if
paramswasundefined. Updatethe code to use the default for all falsy values.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.