Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pipeline-to-taskrun] Add custom task that runs a Pipeline as a TaskRun 🍙 #770

Merged
merged 2 commits into from
Sep 2, 2021
Merged

[pipeline-to-taskrun] Add custom task that runs a Pipeline as a TaskRun 🍙 #770

merged 2 commits into from
Sep 2, 2021

Commits on Sep 2, 2021

  1. Add custom task that runs a Pipeline as a TaskRun 🍙 

    This commit adds a custom task that allows user to run simple sequential
Pipelines as one TaskRun - which means the Pipeline can refer to
multiple Tasks but run on only one pod.

It only supports a subset of Pipeline functionality (more detail on what
and why in the README) but is enough that folks can do a lot of what
they would have previously used PipelineResources for, e.g. doing a git
clone and then doing something with the data, in the same pod, and emit
results such as the exact commit sha used.

Next steps will be to expand the functionality supported, get feedback,
and if the feedback is good, promote this to a top level Pipeline API
feature.

Experimental project proposal: tektoncd/community#447
    @bobcatfish
    bobcatfish committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    4133db4 View commit details
    Browse the repository at this point in the history

  2. Work around openapiv2 case issue 🖍️ 

    Building the custom task on my mac was working just fine but once we
started to build it with CI it failed with
`no required module provides package github.com/googleapis/gnostic/OpenAPIv2`

Turns out this is a known issue:
kubernetes/client-go#741

Kinda at a loss as to why other custom tasks aren't running into this
and my understanding of go mod is so shallow that I feel like I'm
writing with a crayon to fix this (nothing against crayons, they make
cool marks) - but anyway I tried to copy what the pipeline go.mod had
done since I think that's where the original version came from anyway
https://github.com/tektoncd/pipeline/blob/main/go.mod
    @bobcatfish
    bobcatfish committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    388450e View commit details
    Browse the repository at this point in the history