Add digest for static images #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images that are not build as part of the project (buildah, skopeo, …) won't get their digest replaced later on (at least downstream) and thus rendering the build half working. This fixes it manually. Idea might be, long-term, to automate updating those (or at least centralize where their digest is listed) Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
requested review from
concaf,
nikhil-thomas,
pradeepitm12 and
sm43
tekton-robot
added
the
size/S
|
/approve |
tekton-robot
added
the
approved
|
✅ lgtm |
|
cc @piyush-garg |
concaf
approved these changes
Jan 4, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: concaf, nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Images that are not build as part of the project (buildah, skopeo, …)
won't get their digest replaced later on (at least downstream) and
thus rendering the build half working. This fixes it manually. Idea
might be, long-term, to automate updating those (or at least
centralize where their digest is listed)
Signed-off-by: Vincent Demeester [email protected]
/cc @pradeepitm12 @nikhil-thomas @sm43 @concaf
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes