Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openshift] Add ubi-minimal to fetch-latest-sha script #693

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[openshift] Add ubi-minimal to fetch-latest-sha script #693

merged 1 commit into from
Mar 21, 2022

Conversation

nikhil-thomas
Copy link
Member

Add registry.redhat.io/ubi8/ubi-minimal to the list of images for
which latest sha needs to be looked up

Expose maven-settings step image in maven task as an environment
variable in operator depoloyment

Signed-off-by: Nikhil Thomas [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 21, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2022
@sm43
Copy link
Member

sm43 commented Mar 21, 2022

do we have a transformer in place for
Expose maven-settings step image in maven task as an environment variable in operator depoloyment?

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@nikhil-thomas
Copy link
Member Author

/retest

@nikhil-thomas
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@nikhil-thomas
[openshift] Add ubi-minimal to fetch-latest-sha script
e08f71a 
Add `registry.redhat.io/ubi8/ubi-minimal` to the list of images for
which latest sha needs to be looked up

Expose `maven-settings` step image in maven task as an environment
variable in operator depoloyment

Signed-off-by: Nikhil Thomas <[email protected]>
@nikhil-thomas
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@nikhil-thomas
Copy link
Member Author

do we have a transformer in place for Expose maven-settings step image in maven task as an environment variable in operator depoloyment?

one thing we did right is to keep our step and param transformation generic. So for this adding the env is sufficient.

I manual tested on OpenShift 4.10. I works.

@sm43 sm43 added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
pradeepitm12
pradeepitm12 approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 8fa7f52 into tektoncd:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@concaf concaf Awaiting requested review from concaf

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhil-thomas @sm43 @tekton-robot @vdemeester @pradeepitm12