-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openshift] Add ubi-minimal to fetch-latest-sha script #693
Conversation
do we have a transformer in place for |
/retest |
/hold |
6fa545b
to
8785b0f
Compare
Add `registry.redhat.io/ubi8/ubi-minimal` to the list of images for which latest sha needs to be looked up Expose `maven-settings` step image in maven task as an environment variable in operator depoloyment Signed-off-by: Nikhil Thomas <[email protected]>
8785b0f
to
e08f71a
Compare
/hold cancel |
one thing we did right is to keep our step and param transformation generic. So for this adding the env is sufficient. I manual tested on OpenShift 4.10. I works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
registry.redhat.io/ubi8/ubi-minimal
to the list of images forwhich latest sha needs to be looked up
Expose
maven-settings
step image in maven task as an environmentvariable in operator depoloyment
Signed-off-by: Nikhil Thomas [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes