-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replacement environment variable for workingdirinit-image
#695
Add replacement environment variable for workingdirinit-image
#695
Conversation
Add a new environment variable for repalcing `workingdirinit-image` in openshift releases. Signed-off-by: Nikhil Thomas <[email protected]>
/retest |
/lgtm |
@@ -56,6 +56,13 @@ image-substitutions: | |||
containerName: openshift-pipelines-operator | |||
envKeys: | |||
- IMAGE_PIPELINES_ARG__KUBECONFIG_WRITER_IMAGE | |||
- image: registry.redhat.io/openshift-pipelines/pipelines-workingdirinit-rhel8@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we re-use an existing image ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can, if we decide so.
Let us merge this as this follows the default expectation.
Then if we decide to use an existing image, we can change the image name part. This entry will server as a placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good 👍🏼
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a new environment variable for repalcing
workingdirinit-image
inopenshift releases.
We have a new image in tektoncd/pipeline
workingdirinit-image
. Added by: Support workingDir init on Windows #4475used here: https://github.com/tektoncd/pipeline/blob/3c6354c3e9ce5761725bf99499f91d002be4503b/config/controller.yaml#L74
Signed-off-by: Nikhil Thomas [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes