-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace imperative Requeue calls with a declarative Requeue event #713
Conversation
Replace explicit Requeue reconciler-event (enqueue) calls with an a return error (event) of type `requeueKeyError` This approach lets the knative generated reconciler code to do the requeuing when we pass our intent by returning an `event` of type `requeueKeyError`. Signed-off-by: Nikhil Thomas <[email protected]>
2f396df
to
ceed18d
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replace explicit Requeue reconciler-event (enqueue) calls with an
a return error (event) of type
requeueKeyError
This approach lets the knative generated reconciler code to do the
requeuing when we pass our intent by returning an
event
of typerequeueKeyError
.Signed-off-by: Nikhil Thomas [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes