-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fetch script to use stable tag for pac by default #740
Conversation
/test pull-tekton-operator-unit-tests |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hack/fetch-releases.sh
Outdated
@@ -105,7 +105,11 @@ release_yaml_pac() { | |||
rm -rf ${dirPath} || true | |||
mkdir -p ${dirPath} || true | |||
|
|||
url="https://raw.githubusercontent.com/openshift-pipelines/pipelines-as-code/release-${version}/release-${version}.yaml" | |||
if [[ ${version} == "stable" ]]; then | |||
url="https://raw.githubusercontent.com/openshift-pipelines/pipelines-as-code/stable/release.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way we could "go" is : for all we use the github api and release page instead as it is published there for all our components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but do we have latest
tag for other components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could fetch all tags and check which is latest
Signed-off-by: Shivam Mukhade <[email protected]>
ba8c394
to
30e7748
Compare
/lgtm |
Signed-off-by: Shivam Mukhade [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes