Skip to content

Commit

Permalink
Migrate PullRequestResource to go-scm.
Browse files Browse the repository at this point in the history
This changes the underlying implementation of the PullRequestResource
to jenkins-x/go-scm in order to take advantage of the repo drivers to
support other SCM providers.

In the process, this also allowed for refactoring to have a cleaner
distinction between interaction with SCM APIs and converting the data to
an on disk format.

BREAKING CHANGES:
* go-scm does not yet support updating comments, so that behavior is
removed for the time being since:
  1) it's unclear if anyone is actively
  using it.
  2) this behavior can be roughly replicated with a delete +
  create.
  3) the benefits of having the other SCM providers outweighs this
  feature.

Fixes #1066.
  • Loading branch information
wlynch committed Nov 6, 2019
1 parent 5a22142 commit 0e1c21e
Show file tree
Hide file tree
Showing 228 changed files with 12,903 additions and 44,684 deletions.
98 changes: 54 additions & 44 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 0 additions & 15 deletions cmd/pullrequest-init/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,3 @@ Currently supported providers:
## Generic pull request payload

For information about the payloads written to disk, see the [resource documentation](../../docs/resources.md#pull-request-resource).

### Status code conversion

Tekton Status Code | GitHub Status State
------------------ | -------------------
success | success
neutral | success
queued | pending
in_progress | pending
failure | failure
unknown | error
error | error
timeout | error
canceled | error
action_required | error
Loading

0 comments on commit 0e1c21e

Please sign in to comment.