Skip to content

Commit

Permalink
Apply final markdown lint changes
Browse files Browse the repository at this point in the history
  • Loading branch information
mrutkows committed May 21, 2021
1 parent 09b8ae7 commit 12cc3b7
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ Besides, if your registry `KO_DOCKER_REPO` is private, then you also should crea
and add it to `tekton-pipelines-controller` and `tekton-pipelines-webhook` ServiceAccounts accordingly to pull images.
1. Create a secret
```yaml
kubectl create secret docker-registry ${SECRET_NAME} \
--docker-username=${USERNAME} \
Expand Down Expand Up @@ -286,7 +287,6 @@ The recommended minimum development configuration is:
```
> **Note** The recommended [GCE machine type](https://cloud.google.com/compute/docs/machine-types) is `n1-standard-4`
> **Note** that
[the `--scopes` argument to `gcloud container cluster create`](https://cloud.google.com/sdk/gcloud/reference/container/clusters/create#--scopes)
controls what GCP resources the cluster's default service account has access
Expand Down Expand Up @@ -408,20 +408,20 @@ To look at the logs for individual `TaskRuns` or `PipelineRuns`, see
If you need to add a new CRD type, you will need to add:
1. A yaml definition in [config/](./config)
1. Add the type to the cluster roles in:
- [200-clusterrole.yaml](./config/200-clusterrole.yaml)
- [clusterrole-aggregate-edit.yaml](./config/clusterrole-aggregate-edit.yaml)
- [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml)
1. Add go structs for the types in
1. A yaml definition in [config/](./config)
1. Add the type to the cluster roles in:
- [200-clusterrole.yaml](./config/200-clusterrole.yaml)
- [clusterrole-aggregate-edit.yaml](./config/clusterrole-aggregate-edit.yaml)
- [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml)
1. Add go structs for the types in
[pkg/apis/pipeline/v1alpha1](./pkg/apis/pipeline/v1alpha1) e.g
[condition_types.go](./pkg/apis/pipeline/v1alpha1/condition_types.go) This
should implement the
[Defaultable](./pkg/apis/pipeline/v1alpha1/condition_defaults.go) and
[Validatable](./pkg/apis/pipeline/v1alpha1/condition_validation.go)
interfaces as they are needed for the webhook in the next step.
1. Register it with the [webhook](./cmd/webhook/main.go)
1. Add the new type to the
1. Register it with the [webhook](./cmd/webhook/main.go)
1. Add the new type to the
[list of known types](./pkg/apis/pipeline/v1alpha1/register.go)
_See [the API compatibility policy](api_compatibility_policy.md)._

0 comments on commit 12cc3b7

Please sign in to comment.