Add GetStatusCondition for Run

The "Run" type does not have a GetStatusCondition which means it doesn't fit the "objectWithCondition" interface used to send cloudevents. Add GetStatusCondition to make the type more consistent with TaskRun and Pipelinerun and make it possible to use it as an "objectWithCondition" when sending events. Signed-off-by: Andrea Frittoli <[email protected]>
tektoncd · Mar 10, 2022 · 71237ba · 71237ba
1 parent 38d98f0
commit 71237ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/apis/pipeline/v1alpha1/run_types.go b/pkg/apis/pipeline/v1alpha1/run_types.go
@@ -163,6 +163,11 @@ type RunList struct {
 	Items           []Run `json:"items"`
 }
 
+// GetStatusCondition returns the task run status as a ConditionAccessor
+func (r *Run) GetStatusCondition() apis.ConditionAccessor {
+	return &r.Status
+}
+
 // GetGroupVersionKind implements kmeta.OwnerRefable.
 func (*Run) GetGroupVersionKind() schema.GroupVersionKind {
 	return SchemeGroupVersion.WithKind(pipeline.RunControllerName)

diff --git a/pkg/reconciler/events/cloudevent/interface.go b/pkg/reconciler/events/cloudevent/interface.go
@@ -22,7 +22,7 @@ import (
 	"knative.dev/pkg/apis"
 )
 
-// objectWithCondition is implemented by TaskRun and PipelineRun
+// objectWithCondition is implemented by TaskRun, PipelineRun and Run
 type objectWithCondition interface {
 
 	// Object requires GetObjectKind() and DeepCopyObject()